fix(publisher-ers): Update ERS API usage for v2.x #3149
Conversation
|
@erickzhao Could you please review this change? :) |
There was a problem hiding this comment.
Thank you for this! Does this change maintain backward compatibility with ERS 1.0, or will we need to add additional configuration to support both?
We also had an existing PR from a community member that attempted to fix this issue as well: #3124
The diff on that PR has a bunch of other changes. Can you confirm that those are not needed @ArekSredzki?
|
Thanks @erickzhao, I wasn’t aware of that other PR, I must have missed the notification when I was mentioned. I’ll take a look through that PR now. Perhaps I’ve missed some necessary changes. I’d like to drop support for v1.x if you’re okay with that since it’s very outdated. Updating the server is relatively easy and I’d encourage that all users do so. |
ArekSredzki
changed the title
|
I guess I'm just hesitant to drop support right away in v6 of Forge and I feel like a breaking change should be reserved for v7. Potentially keeping the old code path and deprecating it might be an alternative? Interested in what @electron/forgers think. |
ArekSredzki
force-pushed
the
feature/fix-publish-ers-for-v2.0
branch
2 times, most recently
from
bcd2aff
to
2fd43d0
Compare
|
I brought in most of the changes from the other PR since they were indeed desirable. However, I'd like to avoid adding additional logic to retain backward compatibility. If it's a must, would you be able to add that? |
Recently, v2.0 of electron-release-server was released. This version updated many of the underlying packages and should be adopted by all users of the server. In the process, the API changed due to an change with SailsJS. This corrects the API usage within the ERS publisher plugin to allow users to continue using it. Note that this issue was reported here: ArekSredzki/electron-release-server#314
ArekSredzki
force-pushed
the
feature/fix-publish-ers-for-v2.0
branch
from
2fd43d0
to
7fd414d
Compare
|
Update: I studied the V1.x API more carefully and have confirmed that these changes will work for v1 and v2 since v2 is more strict. As far as I can tell, there are actually some errors in the current mainline implementation since the v1.5.2 API always returns a version's flavor as an object and not a string (as v2 does). |
|
Alright, that's awesome then! Will take another look next week. |
|
@erickzhao Bump :) |
|
Thanks! |
Recently, v2.0 of electron-release-server was released. This version updated many of the underlying packages and should be adopted by all users of the server. In the process, the API changed due to a change with SailsJS. This corrects the API usage within the ERS publisher plugin to allow users to continue using it.
Note that this issue was reported here: ArekSredzki/electron-release-server#314